Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ena-submission): Add ena slack notifications #2396

Merged
merged 3 commits into from
Aug 13, 2024
Merged

feat(ena-submission): Add ena slack notifications #2396

merged 3 commits into from
Aug 13, 2024

Conversation

anna-parker
Copy link
Contributor

@anna-parker anna-parker commented Aug 6, 2024 •
edited
Loading

resolves #

preview URL: https://add-ena-slack-notificatio.loculus.org/

Summary

  1. Use slack_api to upload files to slack. In order to do this our slack_bot had to be given read:files, write:files permissions. Then we needed the bot token and the channel id. Furthermore the bot has to be invited to the channel (\invite @slack_bot). This is done as in Move ncbi_api_key to secrets. #2357
  2. When the ENA submission pipeline finds sequences it would like to submit it will now send a message to our slack channel with a zipped file including those sequences.

Screenshot

image If file upload fails still send a message: image

PR Checklist

  • Confirm this runs on a pod - this works on a preview instance!!!:
image

@anna-parker anna-parker added the preview Triggers a deployment to argocd label Aug 7, 2024
@anna-parker anna-parker marked this pull request as ready for review August 7, 2024 13:34
@anna-parker anna-parker changed the title Add ena slack notifications feat(ena-submission): Add ena slack notifications Aug 7, 2024
@anna-parker anna-parker added the review please PR waiting for final review label Aug 8, 2024
@anna-parker anna-parker mentioned this pull request Aug 11, 2024
Merged
5 tasks
@theosanderson
Copy link
Member

Great!

@anna-parker anna-parker merged commit e76d3eb into main Aug 13, 2024
10 checks passed
@anna-parker anna-parker deleted the add_ena_slack_notifications branch August 13, 2024 11:17
@anna-parker anna-parker mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theosanderson theosanderson theosanderson approved these changes

@chaoran-chen chaoran-chen Awaiting requested review from chaoran-chen

@corneliusroemer corneliusroemer Awaiting requested review from corneliusroemer

Assignees
No one assigned
Labels
preview Triggers a deployment to argocd review please PR waiting for final review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anna-parker @theosanderson